Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added customization of the reference to the message and the signal #367

Merged
merged 1 commit into from
Dec 27, 2024
Merged

Added customization of the reference to the message and the signal #367

merged 1 commit into from
Dec 27, 2024

Conversation

amotov
Copy link

@amotov amotov commented Dec 25, 2024

No description provided.

@rsoika
Copy link
Member

rsoika commented Dec 26, 2024

Hi @amotov
thanks for your contribution. Can you please give a short description about the idea behind your change?

@rsoika rsoika mentioned this pull request Dec 27, 2024
Closed
@rsoika
Copy link
Member

rsoika commented Dec 27, 2024

I analyzed it now in more details and I opened an corresponding issue here #368

@rsoika rsoika merged commit cdec7cb into imixs:master Dec 27, 2024
1 check passed
@rsoika
Copy link
Member

rsoika commented Dec 27, 2024

Thanks again for you valuable contribution!

@rsoika
Copy link
Member

rsoika commented Jan 13, 2025

Hi @amotov
it seems that your code change has broken some functionality that I have overseen. Event definitions others than Signal and Message can no longer be added.
I will fix this, but can you please give a short description why you have committed this code change?

@rsoika rsoika mentioned this pull request Jan 13, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amotov @rsoika