Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(server,cli,web): housekeeping and stricter code style #6751

Merged
merged 37 commits into from
Feb 2, 2024
Merged

chore(server,cli,web): housekeeping and stricter code style #6751

merged 37 commits into from
Feb 2, 2024

Conversation

etnoy
Copy link
Contributor

@etnoy etnoy commented Jan 30, 2024 •
edited
Loading

Inspiration came from #6747 (comment)

This turned into a housekeeping and code style PR in general

  • Add unicorn eslint rules which makes linting more strict across the whole codebase
  • Bump es version
  • Bump ts version

I've been able to fix a surpring number of bugs with this increased linting!

@etnoy etnoy mentioned this pull request Jan 30, 2024
Merged
@etnoy etnoy added 🗄️server cli Tasks related to the Immich CLI labels Jan 30, 2024
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jan 30, 2024 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 69e0706
Status: ✅  Deploy successful!
Preview URL: https://2765e23e.immich.pages.dev
Branch Preview URL: https://chore-eslint-unicorn-plugin.immich.pages.dev

View logs

jrasm91
jrasm91 reviewed Jan 30, 2024
View reviewed changes
cli/src/commands/upload.ts Outdated Show resolved Hide resolved
benmccann
benmccann reviewed Jan 30, 2024
View reviewed changes
Copy link
Contributor

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

personally, I'm not a fan of the prevent-abbreviations rule. things like dir are so common that everyone knows what they mean and all that typing out directory accomplishes is making things longer

cli/src/commands/upload.command.ts Outdated Show resolved Hide resolved
cli/src/commands/upload.command.ts Outdated Show resolved Hide resolved
etnoy and others added 19 commits January 31, 2024 00:50
@etnoy
Merge branch 'main' of https://github.com/immich-app/immich into chor…
de12ccf 
…e/eslint-unicorn-plugin
@etnoy @benmccann
Update cli/src/commands/upload.command.ts
ccb10a5 
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
@etnoy
es2k23
0f6d62c
@etnoy
Merge branch 'main' of https://github.com/immich-app/immich into chor…
d2c4db1 
…e/eslint-unicorn-plugin
@etnoy
use lowercase os
c12ae01
@etnoy
return undefined album name
9b2d695
@etnoy
fix bug in asset response dto
37969e4
@etnoy
auto fix issues
8d7512c
@etnoy
fix server code style
8e169fd
@etnoy
es2022 and formatting
a7c4142
@etnoy
fix compilation error
f34e461
@etnoy
fix test
0d1adf7
@etnoy
fix config load
7870965
@etnoy
fix last lint errors
5794330
@etnoy
Merge branch 'main' of https://github.com/immich-app/immich into chor…
d34467d 
…e/eslint-unicorn-plugin
@etnoy
set string type
d4c5afb
@etnoy
bump ts
f18d061
@etnoy
start work on web
8fad3f1
@etnoy
web formatting
7b8007d
@benmccann
Copy link
Contributor

What's the reason for the UUIDParamDto as UIDParameterDto changes?

@etnoy etnoy changed the title chore(server,cli): add unicorn to eslint chore(server,cli,web): housekeeping and stricter code style Feb 1, 2024
@etnoy
Copy link
Contributor Author

etnoy commented Feb 1, 2024

What's the reason for the UUIDParamDto as UIDParameterDto changes?

That's likely an artifact from me running eslint --fix. Thanks for spotting!

@etnoy etnoy marked this pull request as ready for review February 1, 2024 23:55
jrasm91
jrasm91 approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! It looks like a good start and we can tweak and refine moving forward.

@jrasm91 jrasm91 merged commit f44fa45 into main Feb 2, 2024
24 checks passed
@jrasm91 jrasm91 deleted the chore/eslint-unicorn-plugin branch February 2, 2024 03:18
@etnoy
Copy link
Contributor Author

etnoy commented Feb 2, 2024

Thanks for working on this! It looks like a good start and we can tweak and refine moving forward.

Thanks for not being too mad about the mess and size of this pr, lol

@jrasm91 jrasm91 added maintenance and removed 🗄️server cli Tasks related to the Immich CLI labels Feb 14, 2024
This was referenced Feb 22, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmccann benmccann benmccann left review comments

@jrasm91 jrasm91 jrasm91 approved these changes

Assignees
No one assigned
Labels
changelog:skip
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@etnoy @benmccann @jrasm91