Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): notification number of people when editing faces #7352

Merged
merged 18 commits into from
Apr 19, 2024

Conversation

martabal
Copy link
Member

fix for #7341

Copy link

cloudflare-workers-and-pages bot commented Feb 22, 2024

Deploying immich with  Cloudflare Pages  Cloudflare Pages

Latest commit: 058fc78
Status: ✅  Deploy successful!
Preview URL: https://23337dcb.immich.pages.dev
Branch Preview URL: https://fix-edit-faces-notification.immich.pages.dev

View logs

Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have null and undefined types in the list in the first place? Can you just add truthy values to begin with?

@martabal
Copy link
Member Author

That's what I was doing before #6751

Do you prefer something like that ? selectedPersonToReassign = Array.from({ length: peopleWithFaces.length }, () => null);

@martabal martabal closed this Mar 21, 2024
@martabal martabal deleted the fix/edit-faces-notification branch March 21, 2024 18:50
@waclaw66
Copy link
Contributor

waclaw66 commented Apr 2, 2024

May I ask why this fix was closed without merge?

@martabal
Copy link
Member Author

martabal commented Apr 2, 2024

I had too many opened PRs. I will re-open it this evening

@martabal martabal restored the fix/edit-faces-notification branch April 2, 2024 17:29
@martabal martabal reopened this Apr 2, 2024
@martabal martabal requested a review from jrasm91 April 8, 2024 17:58
@jrasm91 jrasm91 merged commit efd8f0d into main Apr 19, 2024
28 checks passed
@jrasm91 jrasm91 deleted the fix/edit-faces-notification branch April 19, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants