Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mobile): Adds blurhash #7055

Closed
wants to merge 3 commits into from
Closed

feat(mobile): Adds blurhash #7055

wants to merge 3 commits into from

Conversation

martyfuhry
Copy link
Contributor

@martyfuhry martyfuhry commented Feb 12, 2024

Adds blur hash to the thumbnails and animates them in using an AnimatedSwitcher from the asset grid.

We tried to implement thumbhash support in #7016 but it became a little unwieldy once we added in the Animated Switcher here.

This branch contains almost everything from that other PR, so it's completely dependent on that being merged in first. Once that merges in, this PR can be cleaned up significantly.

Copy link

cloudflare-workers-and-pages bot commented Feb 12, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9fa2188
Status: ✅  Deploy successful!
Preview URL: https://75414ffb.immich.pages.dev
Branch Preview URL: https://feat-blurhash.immich.pages.dev

View logs

@martyfuhry martyfuhry changed the base branch from refactor/immich-image-provider to main February 12, 2024 18:42
@martyfuhry martyfuhry marked this pull request as draft February 12, 2024 18:50
@shenlong-tanwen shenlong-tanwen marked this pull request as ready for review February 16, 2024 02:38
Copy link
Contributor

@fyfrey fyfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shenlong-tanwen and others added 3 commits February 20, 2024 23:26
* feat(mobile): thumbhash support

* perf(mobile): store bmp thumbhash bytes in Isar

---------

Co-authored-by: shenlong-tanwen <139912620+shalong-tanwen@users.noreply.github.com>
@shenlong-tanwen
Copy link
Member

Closing in favor of #7279

@shenlong-tanwen shenlong-tanwen deleted the feat/blurhash branch March 2, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants