chore: enum support for new API #7110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrasm91
approved these changes
Feb 14, 2024
benmccann
commented
Feb 14, 2024
| @@ -29,7 +28,8 @@ | |||
| JobName.Migration, | |||
| ]; | |||
|
|
|||
| function isSystemConfigJobDto(jobName: JobName): jobName is keyof SystemConfigJobDto { | |||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | |||
There was a problem hiding this comment.
I'm not much of a Typescript expert. Could this be unkown to avoid the any?
|
your changes look good to me! thanks for finishing this up!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jrasm91 has been doing a great job migrating the API over. One of the TODOs from #7103 was enums. I got that setup and working in this PR. I only migrated a single enum as a demonstration to avoid creating merge conflicts with his outstanding PR
Looks like this is causing a bunch of type errors, so there are a bunch of places we'll need to update imports from
@apito@immich/sdk. It's probably best to wait for #7103 before doing that. Feel free to take this over as I have a busy day tomorrow or else I'll get back to it later in the week