[bugfix] - Convert data to string before setting cache (#906)

impactMarket · Sep 21, 2023 · 558ddb8 · 558ddb8
1 parent 195d8ec
commit 558ddb8
Show file tree

Hide file tree

Showing 6 changed files with 449 additions and 301 deletions.
diff --git a/packages/api/package.json b/packages/api/package.json
@@ -18,7 +18,8 @@
  "prettier:dryrun": "prettier -l \"./**/*.ts\"",
  "eslint:dryrun": "eslint \"./**/*.ts\" --max-warnings=0",
  "prettier": "prettier --write \"./**/*.ts\"",
- "eslint": "eslint --fix \"./**/*.ts\" --max-warnings=0"
+ "eslint": "eslint --fix \"./**/*.ts\" --max-warnings=0",
+ "postinstall": "ts-patch install"
  },
  "devDependencies": {
  "@babel/cli": "7.22.5",
@@ -41,7 +42,9 @@
  "express-status-monitor": "1.3.4",
  "mocha": "10.2.0",
  "nodemon": "3.0.1",
- "prettier": "3.0.0"
+ "prettier": "3.0.0",
+ "ts-node": "10.9.1",
+ "ts-patch": "3.0.2"
  },
  "dependencies": {
  "@appsignal/nodejs": "3.0.14",
@@ -69,6 +72,7 @@
  "ts-node": "10.9.1",
  "tsconfig-paths": "4.2.0",
  "twilio": "4.16.0",
- "typescript": "5.2.2"
+ "typescript": "5.2.2",
+ "typia": "5.0.4"
  }
 }
diff --git a/packages/api/src/middlewares/cache-redis.ts b/packages/api/src/middlewares/cache-redis.ts
@@ -1,3 +1,4 @@
+import { json as JSON } from 'typia';
 import { NextFunction } from 'express';
 import { RequestWithUser } from './core';
 import { database } from '@impactmarket/core';
@@ -18,13 +19,13 @@ export const cache =
  '__express__' + (req.originalUrl || req.url) + (useUserCache && req.user ? `user${req.user!.userId}` : '');
  const cachedBody = await redis.get(key);
  if (cachedBody) {
- res.send(cachedBody);
+ res.send(JSON.isParse(cachedBody));
  } else {
  res.sendResponse = res.send;
  res.send = (body: any) => {
  // Only cache if the response is 200
  if (res.statusCode === 200) {
- redis.set(key, body, 'EX', duration);
+ redis.set(key, JSON.stringify(body), 'EX', duration);
  }
  res.sendResponse(body);
  };

diff --git a/packages/api/src/routes/v2/claimLocation.ts b/packages/api/src/routes/v2/claimLocation.ts
@@ -2,6 +2,8 @@ import { Router } from 'express';
 
 import { ClaimLocationController } from '../../controllers/v2/claimLocation';
 import { authenticateToken } from '../../middlewares';
+import { cache } from '../../middlewares/cache-redis';
+import { cacheIntervals } from '../../utils/api';
 import claimLocationValidators from '../../validators/claimLocation';
 
 export default (app: Router): void => {
@@ -23,8 +25,7 @@ export default (app: Router): void => {
  * "403":
  * description: "Invalid input"
  */
- route.get('/', controller.getAll);
- // route.get('/', cache(cacheIntervals.oneDay), controller.getAll);
+ route.get('/', cache(cacheIntervals.oneDay), controller.getAll);
 
  /**
  * @swagger

diff --git a/packages/api/src/routes/v2/global.ts b/packages/api/src/routes/v2/global.ts
@@ -12,6 +12,5 @@ export default (app: Router): void => {
 
  route.get('/numbers', cache(cacheIntervals.oneHour), globalController.numbers);
 
- // temporarly remove cache
- route.get('/demographics', globalController.globalDemographics);
+ route.get('/demographics', cache(cacheIntervals.oneHour), globalController.globalDemographics);
 };
diff --git a/packages/api/tsconfig.json b/packages/api/tsconfig.json
@@ -25,8 +25,14 @@
  "~services/*": ["services/*"],
  "~utils/*": ["utils/*"],
  "~config/*": ["config/*"]
- }
- },
+ },
+ "plugins": [
+ {
+ "transform": "typia/lib/transform"
+ }
+ ],
+ "strictNullChecks": true
+ },
  "include": ["src"],
  "exclude": ["node_modules"]
 }