[bugfix] - Convert data to string before setting cache #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 19, 2023 14:10
dev-jotape
force-pushed
the
fix/redis
branch
from
29fc47f
to
3aa39ad
Compare
vibern0
approved these changes
Sep 21, 2023
packages/api/package.json
Outdated
| "prettier": "3.0.0", | ||
| "ts-node": "10.9.1", | ||
| "ts-patch": "3.0.2", | ||
| "typescript": "5.2.2" |
There was a problem hiding this comment.
hmm, I think you don't need typescript here since you have it on dependencies
|
Kudos, SonarCloud Quality Gate passed!
|
dev-jotape
pushed a commit
that referenced
this pull request
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #gh-issue-number
Changes
Redis was crashing on trying to convert arrays to strings to save on the cache. So, we are first converting the data to string before calling the
redis.set().Additionally, we add the library
typiato start some experiments. First we are using thetypia.stringifyandtypia.isParseon redis middleware.Tests