Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate attestation libraries #308

Closed

Conversation

github-actions[bot]
Copy link
Contributor

This PR updates the attestation libraries generated using protoc.

@pxp928
Copy link
Member

pxp928 commented Dec 12, 2023

This reverting back to an older version. Updated the workflow in this PR: #309

@github-actions github-actions bot force-pushed the actions-regenerate-attestation-libraries branch 2 times, most recently from aea9f9a to 4f031d7 Compare December 13, 2023 16:53
@marcelamelara
Copy link
Contributor

@pxp928 should we close this one then?

@pxp928
Copy link
Member

pxp928 commented Dec 13, 2023

Yes we can close this one

@adityasaky
Copy link
Member

adityasaky commented Dec 13, 2023

Also, this includes a python virtual environment. I think that needs to be gitignored? From https://github.com/in-toto/attestation/blob/main/python/Makefile.

@github-actions github-actions bot force-pushed the actions-regenerate-attestation-libraries branch 2 times, most recently from 918b816 to 48fc9c5 Compare December 18, 2023 14:06
Signed-off-by: GitHub <noreply@github.com>
@github-actions github-actions bot force-pushed the actions-regenerate-attestation-libraries branch from 48fc9c5 to 95888ef Compare December 19, 2023 21:36
@marcelamelara
Copy link
Contributor

marcelamelara commented Dec 19, 2023

This will rebase once #314 is merged, so we can handle merging this PR after that.

@github-actions github-actions bot force-pushed the actions-regenerate-attestation-libraries branch from 95888ef to dcf9b31 Compare December 20, 2023 00:50
@github-actions github-actions bot closed this Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants