Add python venv dir to gitignore #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aditya Sirish <aditya@saky.in>
adityasaky
force-pushed
the
update-gitignore
branch
from
7464e88 to
da0b843
Compare
adityasaky
changed the title
|
I think this is a needed change, but the more robust solution is to have the Python tests clean up the venv when they're done, I think. |
marcelamelara
approved these changes
Dec 19, 2023
adityasaky
force-pushed
the
update-gitignore
branch
from
e62318d to
c46fd9b
Compare
Signed-off-by: Aditya Sirish <aditya@saky.in>
adityasaky
force-pushed
the
update-gitignore
branch
from
c46fd9b to
afb94ae
Compare
pxp928
reviewed
Dec 20, 2023
pxp928
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#308 checks in a full virtual environment, which we ought to avoid...