Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python venv dir to gitignore #314

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Add python venv dir to gitignore #314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da0b843
Add python venv dir to gitignore
adityasaky Dec 19, 2023
afb94ae
Add clean up and minor fix to Python makefile
adityasaky Dec 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,4 @@ node_modules
\#*\#
dist
__pycache__
env
8 changes: 6 additions & 2 deletions python/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ all:
dev: $(VENV_STAMP)

$(VENV_STAMP): pyproject.toml
python -m venv env
python -m venv $(VENV)
$(VENV_BIN)/python -m pip install --upgrade pip
$(VENV_BIN)/python -m pip install -e .[$(INSTALL_EXTRA)]

Expand All @@ -49,7 +49,7 @@ reformat: $(VENV_STAMP)

.PHONY: test tests
test tests: $(VENV_STAMP)
. env/bin/activate && \
. $(VENV_BIN)/activate && \
pytest --cov=$(PY_MODULE) $(T) $(TEST_ARGS) && \
python -m coverage report -m $(COV_ARGS)

Expand All @@ -61,3 +61,7 @@ package: $(VENV_STAMP)
.PHONY: edit
edit:
$(EDITOR) $(ALL_PY_SRCS)

.PHONY: clean
pxp928 marked this conversation as resolved.
Show resolved Hide resolved
clean:
rm -r $(VENV)