Adopt pylint 2.6.0 update #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bad-whitespace was removed in 2.6.0, with the suggestion to use black instead. Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
bad-continuation was removed in 2.6.0, with the suggestion to use black instead. Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
Allow Python 2 style calls of super() with arguments, by disabling the corresponding pylint check, added in pylint 2.6.0. Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
Versions 2.6.0 and later of pylint adhere to PEP 3134 and trigger a 'raise-missing-from' warning (W0707) when chained exceptions are raised implicitly. The 'from' keyword is a Python3.x feature, that is why six.raise_from is used for Python2.x compatibility. Kudos to @sechkova and @jku for showing how to do this (theupdateframework/python-tuf#1116). Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
adityasaky
approved these changes
Aug 27, 2020
There was a problem hiding this comment.
LGTM, thanks @lukpueh!
cc @kristelfung you'll have to rebase to incorporate these changes to avoid the linter failure in your PR. 😄
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #:
None
Description of the changes being introduced by the pull request:
Each commit addresses a separate pylint warning. See commit messages for details.
Please verify and check that the pull request fulfills the following
requirements: