Re-raise exceptions explicitly using the 'from' keyword #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Versions 2.6.0 and later of pylint adhere to PEP 3134 and trigger a 'raise-missing-from' warning (W0707) when chained exceptions are raised implicitly. The 'from' keyword is a Python3.x feature, that is why six.raise_from is used for Python2.x compatibility. Signed-off-by: Teodora Sechkova <tsechkova@vmware.com>
sechkova
force-pushed
the
raise-missing-from
branch
from
e487b5f
to
0ebe226
Compare
lukpueh
added a commit
to lukpueh/in-toto
that referenced
this pull request
Aug 24, 2020
Versions 2.6.0 and later of pylint adhere to PEP 3134 and trigger a 'raise-missing-from' warning (W0707) when chained exceptions are raised implicitly. The 'from' keyword is a Python3.x feature, that is why six.raise_from is used for Python2.x compatibility. Kudos to @sechkova and @jku for showing how to do this (theupdateframework/python-tuf#1116). Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
lukpueh
approved these changes
Aug 24, 2020
There was a problem hiding this comment.
Thanks, @sechkova! LGTM. I borrowed your fix and commit message in in-toto/in-toto#387. I hope you don't mind. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #: #1115
Description of the changes being introduced by the pull request:
Versions 2.6.0 and later of pylint adhere to PEP 3134 and trigger a 'raise-missing-from' warning (W0707) when chained exceptions are raised implicitly.
The 'from' keyword is a Python3.x feature, that is why six.raise_from is used for Python2.x compatibility.
Please verify and check that the pull request fulfills the following
requirements: