-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add localization support #53
Comments
See below for a mock-up on the French language selection for desktop and mobile. Some design notes:
|
@jhung One thought about this—it's possible that further translations may be contributed in the future, in which case a different UI for switching languages would be needed. For Accessibility in Action, I'm using a disclosure menu similar to Pinecone (reference implementation was found here: https://www.w3.org/TR/wai-aria-practices/examples/disclosure/disclosure-navigation.html). |
To address this issue we will need to update to v0.3.0 of the eleventy-plugin-fluid which includes an updated version of the UIO. This version of UIO requires a dev release of Infusion 4.x. Currently the guide site uses docs-core to source UIO and Infusion, which is also used to operate the sidebar. To minimize dependencies and possible conflicts, we should address #54 first to remove the sidebar. In this way, the docs-core dependency can be removed with work on this issue. |
I think for now, since there is only 1 language to choose a simple link is sufficient for what is needed. When more languages are available, then what you propose is definitely an approach to take. I suppose an argument can be made to spend the time now (while we have it) to implement the disclosure approach even if there only 1 language. @jobara @greatislander thoughts? |
I think it might be a good idea to implement a disclosure approach now— then the only barrier to adding new languages would be getting the translations. |
We'll tackle this in #81 I've linked to a start to that work, but because it'll potentially be wrapped up in styling modernization work we decided to break it out. |
Is your feature request related to a problem?
Now that @bliz-ward has created French translations for the Inclusive Design Guide, we need to implement multilingual support in our Eleventy configuration.
Describe the solution you'd like
See fluid-project/trivet#48.
Describe alternative solutions you've considered
Not applicable.
Additional context or notes
Not applicable.
The text was updated successfully, but these errors were encountered: