Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add localization support #53

Closed
greatislander opened this issue Mar 16, 2021 · 6 comments · Fixed by #85
Closed

Add localization support #53

greatislander opened this issue Mar 16, 2021 · 6 comments · Fixed by #85
Assignees
Labels
enhancement New feature or request

Comments

@greatislander
Copy link
Member

Is your feature request related to a problem?

Now that @bliz-ward has created French translations for the Inclusive Design Guide, we need to implement multilingual support in our Eleventy configuration.

Describe the solution you'd like

See fluid-project/trivet#48.

Describe alternative solutions you've considered

Not applicable.

Additional context or notes

Not applicable.

@greatislander greatislander added the enhancement New feature or request label Mar 16, 2021
@greatislander greatislander self-assigned this Mar 16, 2021
@jhung
Copy link
Member

jhung commented Aug 27, 2021

See below for a mock-up on the French language selection for desktop and mobile.

Mobile
Content Page

Some design notes:

  • Figma file can be found here
  • The mock-up is not high-fidelity. Use the existing site's font size, spacing, etc.
  • On desktop, notice that "Francais" is horizontally centred in the available space between the UIO button and the content edge.
  • On mobile, notice that "Francais" is vertically centred in the available space between the UIO bar and the site name.

@greatislander
Copy link
Member Author

@jhung One thought about this—it's possible that further translations may be contributed in the future, in which case a different UI for switching languages would be needed. For Accessibility in Action, I'm using a disclosure menu similar to Pinecone (reference implementation was found here: https://www.w3.org/TR/wai-aria-practices/examples/disclosure/disclosure-navigation.html).

@jobara
Copy link
Member

jobara commented Aug 30, 2021

To address this issue we will need to update to v0.3.0 of the eleventy-plugin-fluid which includes an updated version of the UIO. This version of UIO requires a dev release of Infusion 4.x. Currently the guide site uses docs-core to source UIO and Infusion, which is also used to operate the sidebar. To minimize dependencies and possible conflicts, we should address #54 first to remove the sidebar. In this way, the docs-core dependency can be removed with work on this issue.

@jhung
Copy link
Member

jhung commented Sep 14, 2021

I think for now, since there is only 1 language to choose a simple link is sufficient for what is needed. When more languages are available, then what you propose is definitely an approach to take.

I suppose an argument can be made to spend the time now (while we have it) to implement the disclosure approach even if there only 1 language.

@jobara @greatislander thoughts?

@greatislander
Copy link
Member Author

I think it might be a good idea to implement a disclosure approach now— then the only barrier to adding new languages would be getting the translations.

@jobara
Copy link
Member

jobara commented Sep 27, 2021

I think it might be a good idea to implement a disclosure approach now— then the only barrier to adding new languages would be getting the translations.

We'll tackle this in #81 I've linked to a start to that work, but because it'll potentially be wrapped up in styling modernization work we decided to break it out.

jobara added a commit to jobara/guide.inclusivedesign.ca that referenced this issue Sep 30, 2021
@jobara jobara closed this as completed in 9dbc40e Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants