Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Markdown linting to Gruntfile #44

Merged
merged 8 commits into from
Aug 16, 2021
Merged

feat: add Markdown linting to Gruntfile #44

merged 8 commits into from
Aug 16, 2021

Conversation

greatislander
Copy link
Member

Fix Markdown linting issues, add CI for linting.

See: fluid-project/handbook.floeproject.org#38

@greatislander
feat: add Markdown linting to Gruntfile
adda1a7 
Fix Markdown linting issues, add CI for linting.

See: fluid-project/handbook.floeproject.org#38
@greatislander greatislander added the enhancement New feature or request label Nov 4, 2020
@greatislander greatislander self-assigned this Nov 4, 2020
jobara
jobara reviewed Nov 4, 2020
View reviewed changes
Gruntfile.js Outdated Show resolved Hide resolved
jobara
jobara reviewed Nov 4, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
@greatislander
Copy link
Member Author

@jobara Can you review this again? I think it's ready to merge and I'd like to get it merged soon to avoid further merge conflicts on content changes.

@jobara
Copy link
Member

jobara commented Dec 7, 2020

@greatislander I found a couple of issues with the alt text and <figcaption> being converted to html incorrectly. These appear to be pervasive issues, so I'm going to stop reviewing at this point and will pick up again once they've been addressed.

@greatislander
Copy link
Member Author

@jobara It was necessary to replace the inline HTML with a shortcode for all instances of figure/caption because trying to process Markdown inside HTML was adding extra line breaks. These should all be resolved now.

@greatislander
Copy link
Member Author

@jhung Anything holding this up?

@jhung
Copy link
Member

jhung commented Aug 16, 2021

@greatislander I checked it out and it looks fine to me. Any issues can be addressed separately.

@greatislander
Copy link
Member Author

Okay, great! Please approve and merge at your convenience, @jhung.

@jhung jhung merged commit 744f98d into inclusive-design:main Aug 16, 2021
@greatislander greatislander deleted the add-markdown-linting branch August 16, 2021 19:08
@jobara
Copy link
Member

jobara commented Aug 23, 2021

As a note, I'm migrating over to fluid-lint-all with work on #53, but will include the markdown linting for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dayotte dayotte dayotte left review comments

@the-t-in-rtf the-t-in-rtf the-t-in-rtf left review comments

@jhung jhung Awaiting requested review from jhung

@gtirloni gtirloni Awaiting requested review from gtirloni

@jobara jobara Awaiting requested review from jobara

Assignees

@greatislander greatislander

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@greatislander @jobara @jhung @the-t-in-rtf @dayotte