Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate InlinedExpressionGenMapper recursion from DAG recursion #448

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

majosm
Copy link
Collaborator

@majosm majosm commented Jul 25, 2023

Calls CodeGenMapper.rec() for IndexLambda's bound arrays up front before calling InlinedExpressionGenMapper in order to reduce the overall recursion depth.

@majosm majosm marked this pull request as ready for review July 25, 2023 17:17
@majosm majosm force-pushed the separate-inlined-expression-recursion branch from 19edd9a to ec49db7 Compare July 26, 2023 22:17
@majosm
Copy link
Collaborator Author

majosm commented Jul 26, 2023

@inducer I think this is ready for a look (I don't have permissions to request a review).

@majosm majosm force-pushed the separate-inlined-expression-recursion branch from ec49db7 to d579d3a Compare July 27, 2023 14:08
@inducer inducer merged commit 4743d05 into inducer:main Jul 27, 2023
@inducer
Copy link
Owner

inducer commented Jul 27, 2023

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants