Partially restore recursive forwarding in mappers #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"__call__ = rec" is wrong, doesn't work if subclass overrides rec
|
Thx! |
|
The failures are a consequence of inducer/ci-support@1475971, which in turn appeared because nanobind does not allow I don't totally understand why pytest is unhappy, TBH. |
|
Nvm, I guess I do. It has two ways to import, e.g. |
|
inducer/ci-support@499226c might help, rerunning |
|
Nvm, I was confused. I think adding back the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially undoes #446 by restoring
__call__s that forward torec. Using__call__ = recis wrong, because it doesn't pick up versions ofrecdefined by subclasses.Doesn't appear to have much impact on recursion depth post-#448.