Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev window release version prep #54

Merged

Conversation

brianeray
Copy link
Collaborator

@brianeray brianeray commented Aug 12, 2024

Background

We're trying to do four things with this PR:

  • Adding more structure around development windows by setting up explicitly for the next releases of generator and module plugin subprojects.
  • Correct outdated non-build version references, especially version references from generator code to the module plugin. (See e.g. Gradle error on fresh generated module skeleton #49, which is likely caused by stale plugin version references.)
  • Identify all such references in the sources as a guide for future releases. And perhaps some day automated update by, e.g., Gradle tasks and/or GitHub release workflows.
  • Sync versioning across all projects contained in this monorepo.

Changes

Prepare for upcoming releases of both generator and plugin.

  • Generator core and CLI: 0.1.0-SNAPSHOT > 0.4.0-SNAPSHOT.
  • Module plugin: 0.3.0 > 0.4.0-SNAPSHOT.

Generator currently only scoped for bug fixes, but syncing its version with that of the module plugin for ease of maintenance. Module plugin has bug fixes and an improvement, hence the minor version bump.

generator and gradle-module-plugin are included builds, not subprojects, so there's not an easy way to just set a single version from the root build script.

With fixes for dangling old version strings throughout, especially for generator sources referencing the module plugin version.

These will become 0.4.0 before we release.

Reviewer Notes

Artifacts for these -SNAPSHOT versions may or may not be published. In that sense they may break the generator-core and generator-cli subprojects. Generating publically-available snapshot artifacts is not the goal of this PR.

@brianeray brianeray marked this pull request as draft August 12, 2024 22:34
@brianeray brianeray removed the request for review from paul-griffith August 12, 2024 22:34
@brianeray
Copy link
Collaborator Author

brianeray commented Aug 12, 2024

Recommended by an off-GH review: Going to sync the generator versions with the module version for simplicity. The two have marched and can march to their own cadence but the ease of maintenance outweighs "wasting" a version on one or the other. Let's just make them the same version.

* Generator core and CLI: `0.1.0-SNAPSHOT` > `0.4.0-SNAPSHOT`.
* Module plugin: `0.3.0` > `0.4.0-SNAPSHOT`.

Generator currently only scoped for bug fixes, but syncing its version
with that of the module plugin for ease of maintenance. Module
plugin has bug fixes and an improvement, hence the minor
version bump.

`generator` and `gradle-module-plugin` are included builds, not
subprojects, so there's not an easy way to just set a single version
from the root build script.

With fixes for dangling old version strings throughout, especially for
generator sources referencing the module plugin version.

These will become `0.4.0` before we release.
@brianeray brianeray force-pushed the prepare-next-release branch from 28484e4 to 54a6c05 Compare August 12, 2024 23:09
@brianeray brianeray marked this pull request as ready for review August 12, 2024 23:09
@brianeray brianeray merged commit 9b85c7b into inductiveautomation:master Aug 13, 2024
1 check passed
@brianeray brianeray deleted the prepare-next-release branch August 13, 2024 14:15
@brianeray
Copy link
Collaborator Author

brianeray commented Aug 13, 2024

Confirming the Reviewer Notes, the release.yml workflow can't even push a -SNAPSHOT version of the plugin:

> Task :publishPlugins FAILED
Could not reuse POM from pluginMaven publication because mavenCoordinates() was used
Publishing plugin io.ia.sdk.modl version 0.4.0-SNAPSHOT

 ...

* What went wrong:
Execution failed for task ':publishPlugins'.
> Failed to post to server.
  Server responded with:
  Version must not end with '-SNAPSHOT'

Not going to worry about this for now; in fact it's a nice guard during the 0.4.0 dev window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants