0.4.0 final version bump #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bookend companion to #54. |
Groovy syntax to this reference doesn't work; it's a lexical val reference in the Kotlin DSL. We should probably get some Kotlin DSL coverage in our unit tests at some point.
This should also close issue inductiveautomation#49.
brianeray
force-pushed
the
0.4.0-final-rel
branch
from
6766c5d to
ccdee13
Compare
|
Also patches something I missed in #58. 😞 |
brianeray
commented
Aug 28, 2024
| @@ -25,7 +25,7 @@ ignitionModule { | |||
| * the course of a major Ignition (7.9, 8.0, etc) version, except for when the Ignition Platform adds/changes APIs | |||
| * used by the module. | |||
| */ | |||
| requiredIgnitionVersion.set(rootProject.ext.sdk_version) | |||
| requiredIgnitionVersion.set(sdk_version) | |||
There was a problem hiding this comment.
I should never have patched this template in #40. There was only a problem with the modlPluginConfig.groovy template, not this Kotlin DSL template.
paul-griffith
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should also close issue #49.