FI-3358: Check for Duplicate Ids in In-Memory Repositories (#551)

* Add duplicate id exception

Signed-off-by: Vanessa Fotso <vfotso@mitre.org>

* Check for duplicate ids and add spec to check for duplicate entity id

Signed-off-by: Vanessa Fotso <vfotso@mitre.org>

* Fix failing spec due to duplicate ids

Signed-off-by: Vanessa Fotso <vfotso@mitre.org>

* Remove invalid G10 validator url env

Signed-off-by: Vanessa Fotso <vfotso@mitre.org>

* refactored in memorry repo

Signed-off-by: Vanessa Fotso <vfotso@mitre.org>

---------

Signed-off-by: Vanessa Fotso <vfotso@mitre.org>

.env

@@ -1,7 +1,6 @@
 # URL for FHIR validator service
 VALIDATOR_URL=http://localhost/validatorapi
 REDIS_URL=redis://localhost:6379/0
-G10_VALIDATOR_URL=http://localhost/validatorapi
 FHIR_RESOURCE_VALIDATOR_URL=http://localhost/hl7validatorapi
 FHIRPATH_URL=http://localhost/fhirpath
 

lib/inferno/exceptions.rb

@@ -119,5 +119,11 @@ def initialize(id)
         super("ID '#{id}' exceeds the maximum id length of 255 characters")
       end
     end
+
+    class DuplicateEntityIdException < StandardError
+      def initialize(id)
+        super("ID '#{id}' already exists. Ensure the uniqueness of the IDs.")
+      end
+    end
   end
 end

lib/inferno/repositories/in_memory_repository.rb

@@ -1,4 +1,5 @@
 require 'forwardable'
+require_relative '../exceptions'
 
 module Inferno
   module Repositories
@@ -8,7 +9,10 @@ class InMemoryRepository
       def_delegators 'self.class', :all, :all_by_id
 
       def insert(entity)
+        raise Exceptions::DuplicateEntityIdException, entity.id if exists?(entity.id)
+
         all << entity
+        all_by_id[entity.id.to_s] = entity
         entity
       end
 
@@ -17,7 +21,7 @@ def find(id)
       end
 
       def exists?(id)
-        all_by_id.include? id
+        all_by_id.key?(id.to_s)
       end
 
       class << self
@@ -28,13 +32,6 @@ def all
         # @private
         def all_by_id
           @all_by_id ||= {}
-          @all_by_id.length == all.length ? @all_by_id : index_by_id
-        end
-
-        def index_by_id
-          @all_by_id = {}
-          all.each { |klass| @all_by_id[klass.id] = klass }
-          @all_by_id
         end
       end
     end

spec/inferno/entities/test_suite_spec.rb

@@ -7,6 +7,7 @@
     let(:id) { 'GROUP_ID' }
 
     before do
+      suite_class.id(SecureRandom.uuid)
       allow(Class).to receive(:new).with(Inferno::Entities::TestGroup).and_return(group_class)
     end
 

spec/inferno/repositories/presets_spec.rb

@@ -13,7 +13,7 @@
       File.realpath(File.join(Dir.pwd, 'spec/fixtures/simple_preset.json.erb'))
     end
 
-    let(:uuid) { 'very-random-uuid' }
+    let(:uuid) { SecureRandom.uuid }
 
     before { allow(SecureRandom).to receive(:uuid).and_return(uuid) }
 

spec/inferno/repositories/test_suites_spec.rb

@@ -24,4 +24,18 @@
       expect(record).to be_nil
     end
   end
+
+  describe '#insert' do
+    it 'inserts a new suite into the repository' do
+      records = repo.all
+      new_suite = Class.new(Inferno::TestSuite)
+      new_suite.id('suite_id')
+      expect { repo.insert(new_suite) }.to change { records.size }.by(1)
+      expect(records).to include(new_suite)
+    end
+
+    it 'raises an error if the id already exist' do
+      expect { repo.insert(suite) }.to raise_error(Inferno::Exceptions::DuplicateEntityIdException, /already exists/)
+    end
+  end
 end

spec/inferno/web/serializers/test_group_spec.rb

@@ -2,10 +2,10 @@
 
 RSpec.describe Inferno::Web::Serializers::TestGroup do
   let(:group) { InfrastructureTest::SerializerGroup }
-  let(:test) { group.tests.first }
 
   before do
     options_multi_group = Class.new(OptionsSuite::AllVersionsGroup) do
+      id SecureRandom.uuid
       group from: :v1_group,
             required_suite_options: { ig_version: '1' }