Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-3358: Check for Duplicate Ids in In-Memory Repositories #551

Merged
merged 7 commits into from
Oct 31, 2024

Conversation

vanessuniq
Copy link
Contributor

Summary

This PR addresses a performance issue in the JSON API caused by collisions of entity or runnable IDs. Duplicate IDs lead Inferno to reindex tests every time a test is fetched from the repository, significantly impacting performance. To prevent this, the PR introduces a check that detects duplicate IDs before entities are inserted into the repository. If duplicates are found, Inferno will fail to start, prompting the user to resolve the ID collisions.

Testing Guidance

  • Tested with the G10, which contains duplicate test IDs in the US Core Test Kit.
  • Confirmed that Inferno fails to start due to the detected duplicates

Signed-off-by: Vanessa Fotso <vfotso@mitre.org>
Signed-off-by: Vanessa Fotso <vfotso@mitre.org>
Signed-off-by: Vanessa Fotso <vfotso@mitre.org>
Signed-off-by: Vanessa Fotso <vfotso@mitre.org>
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.06%. Comparing base (e3924fd) to head (37fd2fc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #551   +/-   ##
=======================================
  Coverage   84.06%   84.06%           
=======================================
  Files         262      262           
  Lines       11409    11410    +1     
  Branches     1254     1254           
=======================================
+ Hits         9591     9592    +1     
  Misses       1808     1808           
  Partials       10       10           
Flag Coverage Δ
backend 92.19% <100.00%> (+<0.01%) ⬆️
frontend 79.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vanessuniq vanessuniq merged commit f7ca46a into main Oct 31, 2024
10 checks passed
@vanessuniq vanessuniq mentioned this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants