Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add test description #44

Merged
merged 7 commits into from
Dec 3, 2024
Merged

Feature/add test description #44

merged 7 commits into from
Dec 3, 2024

Conversation

il-ngocanh
Copy link
Collaborator

resolves #

This is a:

  • documentation update
  • bug fix with no breaking changes
  • new functionality
  • a breaking change

All pull requests from community contributors should target the main branch (default).

Description & motivation

Add test description.

What's changed

  • dq_issue_log has new column: test_description

Checklist

  • This code is associated with an Issue which has been triaged and accepted for development.
  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Snowflake
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)

@il-ngocanh il-ngocanh requested a review from il-dat November 28, 2024 07:00
jingyu-infinitelambda
jingyu-infinitelambda reviewed Dec 2, 2024
View reviewed changes
Copy link
Contributor

@jingyu-infinitelambda jingyu-infinitelambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!! I left a few comments to nitpick, let me know what you think and whether those are necessary. Thanks!

il-dat
il-dat approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@il-dat il-dat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you both!

@il-dat il-dat merged commit 0369824 into main Dec 3, 2024
0 of 2 checks passed
@il-dat il-dat deleted the feature/add-test-description branch December 3, 2024 02:20
@il-dat il-dat mentioned this pull request Dec 4, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingyu-infinitelambda jingyu-infinitelambda jingyu-infinitelambda left review comments

@il-dat il-dat il-dat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@il-ngocanh @il-dat @jingyu-infinitelambda