Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test description - Unclosed string literal #45

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

il-dat
Copy link
Collaborator

@il-dat il-dat commented Dec 4, 2024

related #44

This is a:

  • documentation update
  • bug fix with no breaking changes
  • new functionality
  • a breaking change

All pull requests from community contributors should target the main branch (default).

Description & motivation

In BigQuery, if no test description defined, the '' in test_description will have the breaks e.g.

'



' as test_description

This is syntax error in BQ

Checklist

  • This code is associated with an Issue which has been triaged and accepted for development.
  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Snowflake
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)

@il-dat il-dat merged commit 3b85843 into main Dec 4, 2024
0 of 2 checks passed
@il-dat il-dat deleted the fix/unclosed-quote-bg-test-description branch December 4, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant