Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): support for kebab-case names #2534

Merged
merged 3 commits into from
Oct 30, 2023
Merged

fix(cli): support for kebab-case names #2534

merged 3 commits into from
Oct 30, 2023

Conversation

frankcalise
Copy link
Contributor

Please verify the following:

  • yarn test jest tests pass with new tests, if relevant

Describe your PR

  • Closes Feature Request: Allow generating kebab-case projects #1391
  • Fixes bun install (needs bunfig.toml to not install peer deps in order for yarn ios to work after a fresh install)
  • Remove bunfig.toml when not using bun as package manager
  • Remove validation check for kebab-case since Expo prebuild will handle the Xcode project generation and strip dashes
  • Formats bundle identifier default to strip dashes from project name if passed in as kebab-case
  • Add dash to the list of allowed isNotAlphaNumeric validation

Screenshots

image

@frankcalise frankcalise linked an issue Oct 22, 2023 that may be closed by this pull request
Feature Request: Allow generating kebab-case projects #1391
Closed
markrickert
markrickert approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@markrickert markrickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i-tested-these changes-with kebab-case and-found-no-issues!

@frankcalise frankcalise merged commit 775c751 into feat/rn-72-expo-49 Oct 30, 2023
1 check passed
@frankcalise frankcalise deleted the fix/cli-kebab branch October 30, 2023 19:06
@frankcalise frankcalise mentioned this pull request Jan 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markrickert markrickert markrickert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Allow generating kebab-case projects
2 participants
@frankcalise @markrickert