Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] fix: drop PascalCase req for ignite #195

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Conversation

frankcalise
Copy link
Collaborator

@frankcalise frankcalise commented Jan 29, 2024

Description

Related Issue

n/a

Motivation and Context

  • Reduce code needed to maintain Ignite specifics
  • More naming options for users

How Has This Been Tested?

create-expo-stack ces-ignite --yarn
cd ces-ignite
yarn ios

Copy link

changeset-bot bot commented Jan 29, 2024

🦋 Changeset detected

Latest commit: 1f51e81

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-expo-stack Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
create-expo-stack-docs ✅ Ready (Inspect) Visit Preview Jan 29, 2024 2:35pm
create-expo-stack-landing-page ✅ Ready (Inspect) Visit Preview Jan 29, 2024 2:35pm

Copy link

@morganick morganick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Collaborator

@danstepanov danstepanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danstepanov danstepanov merged commit ed2e92f into main Jan 29, 2024
5 checks passed
@danstepanov danstepanov deleted the fix/cli-ignite-pascal branch April 2, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants