Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allows specifying the package name when checking dependencies #929

Merged
merged 2 commits into from
Mar 22, 2017
Merged

Allows specifying the package name when checking dependencies #929

merged 2 commits into from
Mar 22, 2017

Conversation

jamonholmgren
Copy link
Member

Currently, Ignite warns if you have the wrong react-native-cli version installed:

~/Documents/Ignite2Experiments > ignite new fontfix
Ignite requires react-native >=2.0.0 to be installed.

You currently have 1.3.0 installed.

To install: npm i -g react-native-cli

However, it's misleading. This allows specifying the npm package name to more accurately reflect what is missing.

@jamonholmgren jamonholmgren self-assigned this Mar 22, 2017
skellock
skellock approved these changes Mar 22, 2017
View reviewed changes
Copy link
Contributor

@skellock skellock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@skellock skellock added this to the 2.0 Beta 8 milestone Mar 22, 2017
@skellock skellock merged commit 4504f5c into master Mar 22, 2017
@skellock skellock deleted the enforce-package-name branch March 22, 2017 18:11
@jamonholmgren jamonholmgren mentioned this pull request Mar 23, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skellock skellock skellock approved these changes

Assignees

@jamonholmgren jamonholmgren

Labels
maintenance
Projects
None yet
Milestone
2.0.0-beta.8
Development

Successfully merging this pull request may close these issues.
2 participants
@jamonholmgren @skellock