Adds sanity check for presence of react-native conflict
#934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamonholmgren
commented
Mar 23, 2017
| @@ -30,12 +30,27 @@ var rnCli = enforceGlobalDependency({ | |||
| optional: false, | |||
| range: '>=2.0.0', | |||
| which: 'react-native', | |||
| package: 'react-native-cli', | |||
| packageName: 'react-native-cli', | |||
There was a problem hiding this comment.
Noticed this was missed from my previous #929 PR.
jamonholmgren
commented
Mar 23, 2017
| versionCommand: 'react-native --version', | ||
| installMessage: 'To install: npm i -g react-native-cli' | ||
| }) | ||
|
|
||
| if (!rnCli) { | ||
| // If `react-native` is installed, it can cause problems with `react-native-cli` |
There was a problem hiding this comment.
Note that I only run this if the react-native-cli check fails. That's because this check is much slower and if we ran it every time ignite ran, we'd add several seconds to the bootup.
|
Since we are targetting es3, @jamonholmgren we will have to remove the multilines in that console.log. Unless you can test that in node 4. If its good, we can add an linter ignore directive. |
skellock
approved these changes
Mar 23, 2017
|
Fixes #940 too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #874.