Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): use stable component keys #5947

Merged
merged 3 commits into from
Jun 21, 2022
Merged

fix(ui): use stable component keys #5947

merged 3 commits into from
Jun 21, 2022

Conversation

sranka
Copy link
Contributor

@sranka sranka commented Jun 20, 2022

Closes #5946

This PR makes sure that stable react keys are used in React lists. See #5946 for details.

@sranka sranka force-pushed the 5946/stable_react_key branch from 16a799e to 4051548 Compare June 20, 2022 12:05
@sranka sranka force-pushed the 5946/stable_react_key branch from 4051548 to 71fdb5a Compare June 20, 2022 12:27
@sranka sranka marked this pull request as ready for review June 20, 2022 12:27
@sranka sranka merged commit c6d237d into master Jun 21, 2022
@sranka sranka deleted the 5946/stable_react_key branch June 21, 2022 09:07
@sranka sranka added this to the 1.10 milestone Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dev: generate stable row keys to avoid frequent DOM replacements
2 participants