fix(ui): repair rendering of AllUsersTableRow #5979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5978
Briefly describe your proposed changes:
The table row re-renders upon any change of the user structure.
What was the problem?
The row did not re-render when user's superAdmin status changed. It was caused by some relict from the past, which excluded superAdmin status from re-rendering. The rows were however completely replaced upon any change in 1.9.4, the buggy code was thus never effective. Cypress tests were hard to do with frequent useless replacements of rows in DOM. #5947 fixed it and ensured that row DOM elements are updated upon changes. As a side-effect, the forgotten wrong behavior of optimized row rendering becomes effective.
What was the solution?
Re-rerender row on change of the user, including superAdmin status.