Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename timestamp to time for consistency #2108

Closed
dashesy opened this issue Mar 28, 2015 · 7 comments · Fixed by #2405
Closed

Rename timestamp to time for consistency #2108

dashesy opened this issue Mar 28, 2015 · 7 comments · Fixed by #2405
Assignees
Labels
Milestone

Comments

@dashesy
Copy link

dashesy commented Mar 28, 2015

time is shorter. While the query results return time, write endpoint expects timestamp for points.

@pauldix
Copy link
Member

pauldix commented Mar 28, 2015

Yep, we even talked about this internally yesterday. We'll be changing to time, but we may keep timestamp in there as an undocumented one. Have to check with a few early partners that this might cause an issue with.

@pauldix pauldix added this to the 0.9.0 milestone Mar 28, 2015
@otoolep otoolep self-assigned this Mar 30, 2015
@otoolep
Copy link
Contributor

otoolep commented Mar 31, 2015

@pauldix -- this is a much simpler code change if we don't have to support timestamp because we can just use straightforward Go marshalling. Go doesn't allow a field to have two possible keys in the JSON.

Please check with the partners when you get a chance.

@imreFitos
Copy link

upvote

@corylanou
Copy link
Contributor

@pauldix is it ok to only have time and not support both time and timestamp? Just checking if we got an answer on it so we can update this ticket.

@imreACTmd
Copy link

checking in if this will happen

@otoolep
Copy link
Contributor

otoolep commented Apr 14, 2015

Yes, it's going to happen.

@imreACTmd
Copy link

cool, waiting for this to drop.

@toddboom toddboom modified the milestones: 0.9.0, 0.9.1 May 8, 2015
jmoses added a commit to jmoses/influxdb-python that referenced this issue Jun 17, 2015
mark-rushakoff pushed a commit that referenced this issue Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants