-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change timestamp to time #2405
change timestamp to time #2405
Conversation
i forgot to mention... i don't know if any of the JavaScript needs updating. i didn't touch it. |
Thanks @neonstalwart -- at first glance this looks like it. We won't be merging this change immediately, as it requires some co-ordination with some external parters. |
@neonstalwart -- we would like to make this change part of the next release. Can you rebase? |
sure. if I don't get to it over the weekend then I should be able to get that in on Monday |
137d054
to
283cc84
Compare
@otoolep... i've rebased and |
Value float64 `json:"value"` | ||
Tags map[string]string `json:"tags,omitempty"` | ||
Metric string `json:"metric"` | ||
Time int64 `json:"time"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm not familiar with opentsdb. did i do the right thing here or is the json going to be "timestamp"
because it's not something we control?
also, should i change |
Thanks @neonstalwart -- I'll kick the CI system now. We're still tracking down the races in the code which result in a failure every so often. To be the change as simple as possible, I suggest not renaming any functions just yet. |
i've changed opentsdb so that the internal tsdbDP has a hopefully the build passes again 😥 |
@otoolep could you kick CI again please? i had a real failure that i've addressed but now this is back to random failures. |
Green build. Thanks @neonstalwart @toddboom -- merge at will. +1 from me. |
this fixes #2108
i don't know if i went further than was expected. i figured it was easier to do it and get someone to review and provide feedback rather than figure out all the details first.