change timestamp to time

[neonstalwart]

this fixes #2108

i don't know if i went further than was expected. i figured it was easier to do it and get someone to review and provide feedback rather than figure out all the details first.

[neonstalwart]

i forgot to mention... i don't know if any of the JavaScript needs updating. i didn't touch it.

[otoolep]

Thanks @neonstalwart -- at first glance this looks like it. We won't be merging this change immediately, as it requires some co-ordination with some external parters.

[otoolep]

@neonstalwart -- we would like to make this change part of the next release. Can you rebase?

[neonstalwart]

sure. if I don't get to it over the weekend then I should be able to get that in on Monday

[neonstalwart]

@otoolep... i've rebased and Test_ServerSingleGraphiteIntegration_NoDatabase works for me locally. could you kick the CI again to see what happens?

[neonstalwart]

i'm not familiar with opentsdb. did i do the right thing here or is the json going to be "timestamp" because it's not something we control?

[neonstalwart]

also, should i change shardGroupByTimestamp to be shardGroupByTime or just leave it as it is?

[otoolep]

Thanks @neonstalwart -- I'll kick the CI system now. We're still tracking down the races in the code which result in a failure every so often.

To be the change as simple as possible, I suggest not renaming any functions just yet.

[neonstalwart]

i've changed opentsdb so that the internal tsdbDP has a Time field which is the json "timestamp" field. http://opentsdb.net/docs/build/html/api_http/put.html#example-single-data-point-put seems to suggest that this is what we should expect from opentsdb json but i thought that consistently using Time in the go data structures was a good idea.

hopefully the build passes again 😥

[neonstalwart]

@otoolep could you kick CI again please? i had a real failure that i've addressed but now this is back to random failures.

[otoolep]

Green build.

Thanks @neonstalwart

@toddboom -- merge at will. +1 from me.