Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing hardwareAddr in uuid v1 generation #10005

Merged
merged 1 commit into from
Jul 9, 2018

Conversation

amallia
Copy link
Contributor

@amallia amallia commented Jun 27, 2018

Required for all non-trivial PRs
  • Sign CLA (if not already signed)
Required only if applicable

You can erase any checkboxes below this note if they are not applicable to your Pull Request.

  • InfluxQL Spec updated
  • Provide example syntax
  • Update man page when modifying a command
  • Config changes: update sample config (etc/config.sample.toml), server NewDemoConfig method, and Diagnostics methods reporting config settings, if necessary
  • InfluxData Documentation: issue filed or pull request submitted <link to issue or pull request>

@ghost ghost added the proposed label Jun 27, 2018
@amallia
Copy link
Contributor Author

amallia commented Jul 9, 2018

@jacobmarble I don't think the failure is related to my changes

@jacobmarble jacobmarble self-assigned this Jul 9, 2018
@jacobmarble
Copy link
Member

jacobmarble commented Jul 9, 2018

@amallia I restarted the CI builder without checking the failure, just see what happens. Also read through this PR and there's nothing to complain about.

@jacobmarble jacobmarble removed the request for review from mark-rushakoff July 9, 2018 15:35
@jacobmarble jacobmarble merged commit 498de81 into influxdata:master Jul 9, 2018
@ghost ghost removed the proposed label Jul 9, 2018
@jacobmarble
Copy link
Member

jacobmarble commented Jul 9, 2018

@amallia thanks for this PR. Short and clear, fixes an obvious mistake.

Curious, was the missing hardware address causing problems for you?

@amallia
Copy link
Contributor Author

amallia commented Jul 9, 2018

I was just poking around in the codebase and saw this bug and thought it was a good idea to fix it.
I am not using influxdb yet. Happy to find out my PR was appreciated.

@e-dard
Copy link
Contributor

e-dard commented Jul 13, 2018

This will need a manual CHANGELOG entry PR.

@e-dard e-dard added this to the 1.7 milestone Jul 13, 2018
jacobmarble pushed a commit that referenced this pull request Jul 13, 2018
gshif added a commit that referenced this pull request Jul 13, 2018
@jacobmarble
Copy link
Member

Thanks, @e-dard. Resolved in #10084

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants