-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing hardwareAddr in uuid v1 generation #10005
Conversation
@jacobmarble I don't think the failure is related to my changes |
@amallia I restarted the CI builder without checking the failure, just see what happens. Also read through this PR and there's nothing to complain about. |
@amallia thanks for this PR. Short and clear, fixes an obvious mistake. Curious, was the missing hardware address causing problems for you? |
I was just poking around in the codebase and saw this bug and thought it was a good idea to fix it. |
This will need a manual |
Required for all non-trivial PRs
Required only if applicable
You can erase any checkboxes below this note if they are not applicable to your Pull Request.
etc/config.sample.toml
), serverNewDemoConfig
method, andDiagnostics
methods reporting config settings, if necessary