Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update changelog for #10005 #10084

Merged
merged 1 commit into from
Jul 13, 2018
Merged

Update changelog for #10005 #10084

merged 1 commit into from
Jul 13, 2018

Conversation

jacobmarble
Copy link
Member

No description provided.

@jacobmarble jacobmarble self-assigned this Jul 13, 2018
@jacobmarble jacobmarble requested a review from gshif July 13, 2018 20:09
@ghost ghost added the review label Jul 13, 2018
@jacobmarble jacobmarble requested a review from e-dard July 13, 2018 20:09
@hercules-influx
Copy link
Contributor

During a run of megacheck the following issues were discovered:

/tmp/759036291/src/github.com/influxdata/influxdb/cmd/store/query/query.go:404:5: this value of line is never used (SA4006)

e-dard
e-dard approved these changes Jul 13, 2018
View reviewed changes
Copy link
Contributor

@e-dard e-dard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gshif gshif merged commit b260a1d into master Jul 13, 2018
@ghost ghost removed the review label Jul 13, 2018
@jacobmarble jacobmarble deleted the jgm-changelog branch July 13, 2018 20:26
@jacobmarble jacobmarble mentioned this pull request Jul 13, 2018
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gshif gshif gshif approved these changes

@e-dard e-dard e-dard approved these changes

Assignees

@jacobmarble jacobmarble

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jacobmarble @hercules-influx @e-dard @gshif