Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix append of possible nil iterator. #10326

Merged
merged 1 commit into from
Oct 8, 2018
Merged

Conversation

benbjohnson
Copy link
Contributor

This commit updates an iterator list to ignore nil iterators.
Adding a nil caused the SeriesIterators.Close() to panic.

This commit updates an iterator list to ignore `nil` iterators.
Adding a `nil` caused the `SeriesIterators.Close()` to panic.
@benbjohnson benbjohnson added this to the 1.7.0 milestone Oct 2, 2018
@benbjohnson benbjohnson self-assigned this Oct 2, 2018
@benbjohnson benbjohnson requested a review from e-dard October 2, 2018 19:20
@ghost ghost added the review label Oct 2, 2018
Copy link
Contributor

@e-dard e-dard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@benbjohnson benbjohnson merged commit b5c82a8 into master Oct 8, 2018
@ghost ghost removed the review label Oct 8, 2018
@benbjohnson benbjohnson deleted the bj-fix-nil-tsi-iterator branch October 8, 2018 14:31
@jsternberg
Copy link
Contributor

Related to #10367.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants