Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix append of possible nil iterator. #10343

Merged
merged 1 commit into from
Oct 15, 2018
Merged

Fix append of possible nil iterator. #10343

merged 1 commit into from
Oct 15, 2018

Conversation

benbjohnson
Copy link
Contributor

Backport #10326

@benbjohnson
Fix append of possible nil iterator.
807b4c7 
This commit updates an iterator list to ignore `nil` iterators.
Adding a `nil` caused the `SeriesIterators.Close()` to panic.
@benbjohnson benbjohnson added this to the 1.6.4 milestone Oct 8, 2018
@benbjohnson benbjohnson self-assigned this Oct 8, 2018
@benbjohnson benbjohnson requested a review from e-dard October 8, 2018 19:46
@ghost ghost added the review label Oct 8, 2018
@benbjohnson benbjohnson merged commit 8c79e9a into 1.6 Oct 15, 2018
@benbjohnson benbjohnson deleted the bj-fix-nil-tsi-iterator-1.6 branch October 15, 2018 16:18
@ghost ghost removed the review label Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartcarnie stuartcarnie stuartcarnie approved these changes

@e-dard e-dard Awaiting requested review from e-dard

Assignees

@benbjohnson benbjohnson

Labels
kind/bug
Projects
None yet
Milestone
1.6.4
Development

Successfully merging this pull request may close these issues.
2 participants
@benbjohnson @stuartcarnie