fix(ui): regression fix, notes are now deletable #16175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
121watts and
ebb-tide
and removed request for
a team
ebb-tide
reviewed
Dec 10, 2019
| @@ -69,6 +69,13 @@ const CellContext: FunctionComponent<Props> = ({ | |||
| onHide={onHide} | |||
| testID="cell-context--note" | |||
| /> | |||
| <CellContextDangerItem | |||
ui/src/clockface/components/inputs/multipleInput/MultipleRows.tsx
Outdated
Show resolved
Hide resolved
| @@ -17,6 +17,7 @@ | |||
| 1. [16105](https://github.com/influxdata/influxdb/pull/16105): Fix crash when loading queries built using Query Builder | |||
| 1. [16112](https://github.com/influxdata/influxdb/pull/16112): Create cell view properties on dashboard creation | |||
| 1. [16172](https://github.com/influxdata/influxdb/pull/16172): Fixed table ui threshold colorization issue where setting thresholds would not change table UI | |||
| 1. [16175](https://github.com/influxdata/influxdb/pull/16175): Added delete functionality to note cells so that they can be deleted | |||
There was a problem hiding this comment.
Actually yes- looking at the code I don't think type= markdown cells were ever able to be deleted??
There was a problem hiding this comment.
That is correct, not sure why they that functionality hadn't been integrated from the outset, but 🤷♂
drdelambre
approved these changes
Dec 11, 2019
alexpaxton
pushed a commit
that referenced
this pull request
Jan 9, 2020
regression fix, notes are now deletable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16170
Problem
No option was given for deleting note cells
Solution
Added the existing delete cell functionality to the dropdown