Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): regression fix, notes are now deletable #16175

Merged
merged 3 commits into from
Dec 11, 2019
Merged

fix(ui): regression fix, notes are now deletable #16175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
20e2987
fix(ui): regression fix, notes are now deletable
asalem1 Dec 10, 2019
5858a9e
chore(ui): updated the changelog to reflect changes
asalem1 Dec 10, 2019
d43e82d
fix(ui): reverted unnecessary changes
asalem1 Dec 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
1. [16105](https://github.com/influxdata/influxdb/pull/16105): Fix crash when loading queries built using Query Builder
1. [16112](https://github.com/influxdata/influxdb/pull/16112): Create cell view properties on dashboard creation
1. [16172](https://github.com/influxdata/influxdb/pull/16172): Fixed table ui threshold colorization issue where setting thresholds would not change table UI
1. [16175](https://github.com/influxdata/influxdb/pull/16175): Added delete functionality to note cells so that they can be deleted
Copy link
Contributor

@ebb-tide ebb-tide Dec 10, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually yes- looking at the code I don't think type= markdown cells were ever able to be deleted??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is correct, not sure why they that functionality hadn't been integrated from the outset, but 🤷‍♂


### UI Improvements

Expand Down
7 changes: 7 additions & 0 deletions ui/src/shared/components/cells/CellContext.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,13 @@ const CellContext: FunctionComponent<Props> = ({
onHide={onHide}
testID="cell-context--note"
/>
<CellContextDangerItem
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

label="Delete"
onClick={handleDeleteCell}
icon={IconFont.Trash}
onHide={onHide}
testID="cell-context--delete"
/>
</div>
)
}
Expand Down