Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: vendoring the ui #19906

Closed
wants to merge 3 commits into from
Closed

feat: vendoring the ui #19906

wants to merge 3 commits into from

Conversation

drdelambre
Copy link
Contributor

to reduce the number of places within our organization that determine the definition of what constitutes our UI offering, we are depreciating the influxdb ui source files in favor of vendoring in compiled assets that are generated from influxdata/ui.

there's some hold up on automating this process, so the first one comes in hand rolled to make the GA

no more waiting for yarn install to run! amirite?!

@mark-rushakoff
Copy link
Contributor

👎 on vendoring in .wasm files and minified javascript files. That will greatly bloat the size of stored git objects in this repo.

Can you instead publish the assets as a github release in the ui repo, and add a make target to download and untar those assets into a .gitignore-d directory?

@danxmoran danxmoran self-requested a review November 20, 2020 14:44
@williamhbaker
Copy link
Contributor

Closing this, as a similar scope was completed by #21090.

@jacobmarble jacobmarble deleted the alex_vendor branch January 2, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants