feat: synchronize ui folder with ui repository #21090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamhbaker
force-pushed
the
wb-ui-sync
branch
from
c9ac04d
to
9d94bc0
Compare
danxmoran
reviewed
Mar 30, 2021
@danxmoran Parts of the UI source are still needed to run the e2e tests - when I tried deleting the |
…h_ui_assets.sh script
danxmoran
reviewed
Mar 30, 2021
…Builder test on chrome
danxmoran
approved these changes
Mar 30, 2021
williamhbaker
force-pushed
the
wb-ui-sync
branch
from
6b476f1
to
e78bc46
Compare
williamhbaker
added a commit
that referenced
this pull request
Apr 1, 2021
* feat: synchronize ui folder with ui repository * docs: updated README in /ui to reflect new UI asset build process * chore: update CHANGELOG * chore: re-worded CHANGELOG message and added trailing newline to fetch_ui_assets.sh script * fix: leveraged queryBuilder test code from ui repo to fix flaky queryBuilder test on chrome * docs: added comments to fetch_ui_assets script explaining where the assets come from * chore: empty commit to trigger CI
williamhbaker
added a commit
that referenced
this pull request
Apr 1, 2021
* feat: synchronize ui folder with ui repository (#21090) * feat: synchronize ui folder with ui repository * docs: updated README in /ui to reflect new UI asset build process * chore: update CHANGELOG * chore: re-worded CHANGELOG message and added trailing newline to fetch_ui_assets.sh script * fix: leveraged queryBuilder test code from ui repo to fix flaky queryBuilder test on chrome * docs: added comments to fetch_ui_assets script explaining where the assets come from * chore: empty commit to trigger CI * chore: update URL in fetch_ui_assets.sh to point to the correct release branch in ui repo * chore: update CHANGELOG
This was referenced Apr 1, 2021
This was referenced Apr 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: influxdata/ui#212 & influxdata/idpe#8963
This change modifies the build process for
influxdrelated to the UI assets. Pre-built UI assets will now be downloaded from tagged releases on theinfluxdata/uirepository and embedded into theinfluxdbinary. This pull request includes modifications to theMakefilein theuifolder necessary to accomplish this. It also includes adjustments to the e2e Cypress tests to allow them to work with the up-to-date UI from theinfluxdata/uirepository. Test adjustments were made to update the tests to match the correct selectors and reduce "flakyness" of the tests.Efforts are being planned to integrate OSS with the
monitor-cie2e tests, see influxdata/ui#1007. Once this is complete, additional cleanup work can be done in theinfluxdata/influxdbrepository related to UI assets once the e2e tests do not need to be run out ofinfluxdata/influxdb.