Move load database config to API #792
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for _, query := range q { | ||
| selectQuery := query.SelectQuery | ||
|
|
||
| if selectQuery.IsContinuousQuery() { |
There was a problem hiding this comment.
Should we throw an error if the query isn't continuous instead of silently ignoring the query ?
There was a problem hiding this comment.
In that case we should probably validate they're all continuous queries that parse before doing anything. That way people won't get into a halfway completed state.
Update the client struct so the Database is public and can be set by library users. Move the db_config API to specify the database name in the URL. Make load config test also test loading continuous queries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #791 - Removed load database config options from the daemon. Created an API endpoint and updated test.
Fix #745 - Added definition of continuous queries to load database config.