Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bigPanda): add TICKscript AST processing #2491

Merged
merged 2 commits into from
Mar 4, 2021
Merged

fix(bigPanda): add TICKscript AST processing #2491

merged 2 commits into from
Mar 4, 2021

Conversation

sranka
Copy link
Contributor

@sranka sranka commented Mar 4, 2021 •
edited
Loading

This PR Fixes TickScript AST processing so that it includes BigPanda alert handler.

Additionally, it also adds a test for serviceNow alert handler AST parsing.

Required for all non-trivial PRs
  • Rebased/mergable
  • Tests pass
  • CHANGELOG.md updated
  • Sign CLA (if not already signed)

@sranka sranka requested review from alespour and rhajek March 4, 2021 11:50
@sranka sranka marked this pull request as ready for review March 4, 2021 11:51
@alespour
Copy link
Contributor

alespour commented Mar 4, 2021

Thanks for ServiceNow alert test that I forgot to add in #2416!

@sranka sranka mentioned this pull request Mar 4, 2021
Merged
5 tasks
@sranka sranka merged commit e6f80d9 into master Mar 4, 2021
@sranka sranka deleted the fix/big_panda_tick_ast branch March 4, 2021 13:46
@sranka sranka mentioned this pull request Apr 28, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alespour alespour alespour approved these changes

@rhajek rhajek rhajek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sranka @alespour @rhajek