fix(teams): add TICKscript AST processing #2542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR follows the same changes that fixed BigPanda in #2491 |
5 tasks
sranka
force-pushed
the
fix/teams_tick_ast
branch
2 times, most recently
from
137a2e7 to
299cb8f
Compare
|
can you point this at master then clean it up? It is otherwise fine. You may need to cherry pick it. |
|
Thank you @docmerlin for pointing to the right branch. #2500 and #2504 are now also pointing to v1.6-master, should we target them to master as well? |
|
Yes, nothing should be pointing to 1.6-master anymore. @sranka |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Fixes TickScript AST processing so that it includes Teams alert handler. This is required in order to fully support Teams alert configuration in Chronograf ( influxdata/chronograf#5732 )
Required for all non-trivial PRs