Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use latest openApi #2919

Merged
merged 3 commits into from
Oct 18, 2021
Merged

chore: use latest openApi #2919

merged 3 commits into from
Oct 18, 2021

Conversation

jrenee42
Copy link
Contributor

@jrenee42 jrenee42 commented Oct 18, 2021 •
edited
Loading

updates to the latest openApi sha for building the backend api that the ui calls.

tweaked the lineProtocol error codes that have changed.

needed for explicit buckets
#2231

@jrenee42 jrenee42 requested a review from a team as a code owner October 18, 2021 19:05
@jrenee42
adjusting code to reflect slightly different error codes for the line…
9017e20 
… Protocol; forbidden (403) is removed, not found (404) and internal service error (500) added; changed 403 clause to 404; and the 500 error will be caught by the final else clause
@ui-ci-bot-influx
Copy link

ui-ci-bot-influx commented Oct 18, 2021 •
edited
Loading

Metric Score Level
performance 57 🔴
accessibility 96 🟢
seo 90 🟢
pwa null 💩
best-practices 100 🟢

Compare your scores with master branch

asalem1
asalem1 approved these changes Oct 18, 2021
View reviewed changes
Copy link
Contributor

@asalem1 asalem1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for getting to the root cause of why the two types diverge. Yet another instance of how we're trying to juggle two different environments in the same repo

@jrenee42 jrenee42 merged commit ed76331 into master Oct 18, 2021
@jrenee42 jrenee42 deleted the chore/useLatestOpenApi branch October 18, 2021 21:08
Dfldr pushed a commit that referenced this pull request Oct 26, 2021
@jrenee42 @Dfldr
chore: use latest openApi (#2919)
8a5227a 
* chore: use latest openApi

* adjusting code to reflect slightly different error codes for the line Protocol; forbidden (403) is removed, not found (404) and internal service error (500) added; changed 403 clause to 404; and the 500 error will be caught by the final else clause

* one more subtle change in lineProtocol, with documentation
@williamhbaker williamhbaker mentioned this pull request Nov 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asalem1 asalem1 asalem1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrenee42 @ui-ci-bot-influx @asalem1