fix: fix stackdriver page #3124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: upgrade react-markdown to 6.0.3 and optimize-css-assets-webpack-plugin, move to custom renderer for OSS and fix OSS test syntax
williamhbaker
commented
Nov 2, 2021
| @@ -68,6 +68,20 @@ export const LineProtocolProvider: FC<Props> = React.memo(({children}) => { | |||
| setWriteError('') | |||
| } | |||
|
|
|||
| /** | |||
hoorayimhelping
approved these changes
Nov 2, 2021
|
|
||
| // Styles | ||
| import 'src/writeData/components/ClientCodeCopyPage/InstallPackageHelper.scss' | ||
|
|
||
| interface Props { | ||
| text: string | ||
| codeRenderer: Renderer<HTMLPreElement> | ||
| codeRenderer: any |
There was a problem hiding this comment.
only concern here is that we're losing type information going from Renderer to any. Is there any way to avoid this?
There was a problem hiding this comment.
Hrmm a valid concern for sure but I'm going to have to punt on it and defer to #3039 which is where this code is from, and matches the impl on master:
I'd guess that there were some changes in the new version of react-markdown that made Rendered no longer compatible, but I can't say for sure. For now I'll keep this code consistent with master, and if it gets changed there in the future we'll pick it up when we create new OSS release branches off of master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3068
This is a backport PR; it is backporting some changes from the
masterbranch intoOSS-2.1to fix a bug that has already been fixed onmaster. We don't want to branch off of the latestmasterat this point because for the 2.1 OSS release (imminent) we aren't planning to release with the clockface updates.Primarily a clean cherry pick of #3039. The file
src/buckets/components/context/lineProtocol.tsxwas updated based on #2919 to take care of a typescript check error.