Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues during testing interchain accounts application #1191

Closed
3 of 5 tasks
Tracked by #1296
, #1279
...
ancazamfir opened this issue Jul 12, 2021 · 0 comments · Fixed by #1172
Closed
3 of 5 tasks
Tracked by #1296
, #1279
...

Issues during testing interchain accounts application #1191

ancazamfir opened this issue Jul 12, 2021 · 0 comments · Fixed by #1172
Assignees
@adizere @ancazamfir

Comments

@ancazamfir
Copy link
Collaborator

Crate

relayer

Summary

With the new revision of ics-27, hermes does not relay the interchain account transfers anymore. This is mainly caused by the different message.action tags and dynamic port-id information.

Version

master

Steps to Reproduce

Use the interchain account repo from cosmos/interchain-accounts-demo#52 that implements the new spec. Run the steps described here with latest hermes.
This step fails:

# Test sending assets from interchain account via ibc.
icad tx intertx send cosmos1plyxrjdepap2zgqmfpzfchmklwqhchq5jrctm0 $VAL_2 500stake --connection-id conection-0 --chain-id test-1 --gas 90000 --home ./data/test-1 --node tcp://localhost:16657 --from val1 -y

Acceptance Criteria

Running the steps described here should be successful up to the channel closing.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ancazamfir ancazamfir mentioned this issue Jul 12, 2021
Merged
6 tasks
This was referenced Aug 19, 2021
Merged
Closed
romac added a commit that referenced this issue Aug 23, 2021
@romac
Add .changelog entry for #1191
368d37b
romac added a commit that referenced this issue Aug 23, 2021
@ancazamfir @romac
Get events from RPC event's data instead of events (#1172)
9eeec52 
* temp fix

* Debugability, add check for chan try for counterparty ch

* Get events from RPC event's data insead of events

* Fix error message

* Debug for proof bytes and getter of other_proof

* fmt fix

* Remove event conversion, redundant with current tendermint-rs refpoint

* Review comments

* Add .changelog entry for #1191

* Fix clippy warning

Co-authored-by: Romain Ruetschi <romain@informal.systems>
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this issue Sep 13, 2022
@ancazamfir @romac
Get events from RPC event's data instead of events (informalsystems#1172
8cf98ea 
)

* temp fix

* Debugability, add check for chan try for counterparty ch

* Get events from RPC event's data insead of events

* Fix error message

* Debug for proof bytes and getter of other_proof

* fmt fix

* Remove event conversion, redundant with current tendermint-rs refpoint

* Review comments

* Add .changelog entry for informalsystems#1191

* Fix clippy warning

Co-authored-by: Romain Ruetschi <romain@informal.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adizere adizere

@ancazamfir ancazamfir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Get events from RPC event's data instead of events informalsystems/hermes
2 participants
@adizere @ancazamfir