Get events from RPC event's data instead of events #1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you foresee any issues integrating these changes against informalsystems/tendermint-rs#918 once a release of tendermint-rs including that PR will be out? |
romac
reviewed
Jul 16, 2021
romac
reviewed
Jul 16, 2021
romac
approved these changes
Aug 23, 2021
5 tasks
5 tasks
5 tasks
|
Nice!! @ancazamfir |
5 tasks
hu55a1n1
added a commit
that referenced
this pull request
Jan 24, 2022
… a tendermint NewBlock event
6 tasks
romac
pushed a commit
that referenced
this pull request
Feb 3, 2022
* Implement conversions for channel events * Implement conversions for packets * Resurrect code (from PR #1172) to extract begin/end-block events from a tendermint NewBlock event * Add channel events in the right order * Remove redundant clones * Minor refactoring * Fix failing CI tests * Extract block events without depending on message.action * Cleanup * Add .changelog entry * Document event extraction
hu55a1n1
pushed a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
) * temp fix * Debugability, add check for chan try for counterparty ch * Get events from RPC event's data insead of events * Fix error message * Debug for proof bytes and getter of other_proof * fmt fix * Remove event conversion, redundant with current tendermint-rs refpoint * Review comments * Add .changelog entry for informalsystems#1191 * Fix clippy warning Co-authored-by: Romain Ruetschi <romain@informal.systems>
hu55a1n1
added a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
* Implement conversions for channel events * Implement conversions for packets * Resurrect code (from PR informalsystems#1172) to extract begin/end-block events from a tendermint NewBlock event * Add channel events in the right order * Remove redundant clones * Minor refactoring * Fix failing CI tests * Extract block events without depending on message.action * Cleanup * Add .changelog entry * Document event extraction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1191
TODOs
message.action, e.g., here.Context for this PR: Simplifies greatly the relayer's RPC events parsing architecture. Additionally, this is a low-hanging fruit to improve the ergonomics of testing with Hermes and Interchain Accounts (ICS27). Main customer benefiting from this: @seantking.
Description
For contributor use:
docs/) and code comments.Files changedin the Github PR explorer.