Client update fails if the client is already up-to-date

[adizere]

Crate

relayer

Summary of Bug

If a client has a consensus state at height x and the latest height for the target chain is x, then Hermes will report success upon trying to update the consensus state of the client, despite encountering an error:

$ hermes tx raw update-client ibc-1 ibc-0 07-tendermint-3
    Finished dev [unoptimized + debuginfo] target(s) in 0.18s
     Running `target/debug/hermes tx raw update-client ibc-1 ibc-0 07-tendermint-3`
{"status":"success","result":{"ChainError":"deliver_tx reports error: log=Log(\"failed to execute message; message index: 0: cannot update client with ID 07-tendermint-3: header height ≤ consensus state height (0-400 ≤ 0-400): invalid client header\")"}}

Version & reproducing

This is easy to reproduce if the target chain is halted (pending an upgrade).
See branch adi/357_upgrade and PR #723 .

Fix description

The patch introduced in #723 solves the present issue by changing Hermes output to the following:

{"status":"error","result":"tx error: error raised while updating client: Client 07-tendermint-4 is already up-to-date with chain ibc-0@revision: 0, height: 400"}

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate milestone (priority) applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned