Hermes CLI for upgrading client

[adizere]

Closes: #357
Closes: #734

Description

• added a new CLI
  • hermes tx raw upgrade-client ibc-1 ibc-0 07-tendermint-1
• testing instructions for the CLI can be found in this guide

Additional notes:

• added the corresponding proto file: proto/src/prost/cosmos.upgrade.v1beta1.rs
• also added the proto-compiler Cargo.lock file (note: this file account for over 1K new lines of code, so the PR is not as big as it seems)
  • also mentioned in proto-compiler that we should use the locked flag so that the binary is identical every time we re-generate these files;
  • this is important to avoid having aesthetic differences in the generated proto files (for example pub log: std::string::String, vs pub log: ::prost::alloc::string::String,)
• added some stubs for the upgrade client handler, but the rest will be handled in a separate issue (Handler for upgrade client #722)
• also cleaned up some rust doc

---

For contributor use:

• Updated the Unreleased section of CHANGELOG.md with the issue.
• If applicable: Unit tests written, added test to CI.
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Updated relevant documentation (docs/) and code comments.
• Re-reviewed Files changed in the Github PR explorer.

[adizere]

Was not used.

[adizere]

Made it more explicit as it wasn't clear from output which was user <> validator.

[codecov-io]

Codecov Report

Merging #723 (4187c40) into master (b1b37f5) will increase coverage by 31.1%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #723      +/-   ##
=========================================
+ Coverage    13.6%   44.8%   +31.1%     
=========================================
  Files          69     166      +97     
  Lines        3752   11318    +7566     
  Branches     1374       0    -1374     
=========================================
+ Hits          513    5078    +4565     
- Misses       2618    6240    +3622     
+ Partials      621       0     -621     

Impacted Files	Coverage Δ
...application/ics20_fungible_token_transfer/error.rs	0.0% <ø> (ø)
...ion/ics20_fungible_token_transfer/msgs/transfer.rs	22.2% <ø> (ø)
..._transfer/relay_application_logic/send_transfer.rs	85.7% <ø> (ø)
modules/src/events.rs	0.0% <ø> (ø)
modules/src/handler.rs	100.0% <ø> (ø)
modules/src/ics02_client/client_consensus.rs	55.8% <ø> (ø)
modules/src/ics02_client/client_def.rs	32.3% <ø> (ø)
modules/src/ics02_client/client_state.rs	65.1% <ø> (ø)
modules/src/ics02_client/client_type.rs	79.1% <ø> (+31.5%)	⬆️
modules/src/ics02_client/context.rs	90.4% <ø> (ø)
... and 266 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2ba84b...4187c40. Read the comment docs.

[adizere]

@ancazamfir @cezarad can you please have a look over this?

[ancazamfir]

FYI, I added a new command upgrade-chain in 42b326a to help with the client upgrade testing. Also removed the patches and dependencies on the Go relayer. Updated the instructions.

[ancazamfir]

Wow, thanks Adi, we are almost done with this! I have a couple of comments on the CLI and UX.

[ancazamfir]

I think we should make dst_client_id optional and if not entered to upgrade all clients of src_chain_id present on dst_chain_id. The way it is, with a lot of clients, the user needs to query all clients and issue the upgrade for each client.
Also, we should have a hermes client upgrade.. command in place of or in addition to this command.

[romac]

Do you want to do this in this PR or a follow-up one? If the latter, then we should open an issue to track this.

[ancazamfir]

Follow up PR, thanks!

[adizere]

#763

[romac]

Awesome, pushed a couple commits for nitpicks and left a comment about a TODO, but otherwise it's all good!