-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for remaining Tendermint RPC endpoints #832
Comments
Not sure why GitHub closed this issue. |
The little robots are pretty dumb, because they missed the most important word in that sentence 😄 |
@thanethomson I made a PR that addresses the |
Is there any update on this? After the yanking of TM 0.35 a lot of these endpoints were removed from the latest TM-rs 0.25 release. |
- Add base64 `tendermint::hash::Hash` encoding/decoding support - Add base64 `Option<tendermint::hash::Hash>` encoding/decoding support - Add missing `FromStr` import - Rename `hash_base64` serializer to `tx_hash_base64` Relates informalsystems#942 Links informalsystems#832
@thanethomson |
* Add block_by_hash RPC endpoint and tests Signed-off-by: Felix C. Morency <1102868+fmorency@users.noreply.github.com> * rpc-probe part of this Signed-off-by: Felix C. Morency <1102868+fmorency@users.noreply.github.com> * Fix comments Signed-off-by: Felix C. Morency <1102868+fmorency@users.noreply.github.com> * Update .changelog/unreleased/features/832-block-by-hash.md Co-authored-by: Thane Thomson <connect@thanethomson.com> Signed-off-by: Felix C. Morency <1102868+fmorency@users.noreply.github.com> * cargo fmt Signed-off-by: Felix C. Morency <1102868+fmorency@users.noreply.github.com> * cargo fmt * Fix TM hash encoding - Add base64 `tendermint::hash::Hash` encoding/decoding support - Add base64 `Option<tendermint::hash::Hash>` encoding/decoding support - Add missing `FromStr` import - Rename `hash_base64` serializer to `tx_hash_base64` Relates #942 Links #832 * Fix outgoing kvstore `block_by_hash` fixture * Fix clippy Signed-off-by: Felix C. Morency <1102868+fmorency@users.noreply.github.com> Co-authored-by: Hans Larsen <hans@larsen.online> Co-authored-by: Thane Thomson <connect@thanethomson.com>
@mzabaluev Can you please take a look at this and update the issue accordingly to the changes introduced in #1193? |
We need to implement client support for the full set of Tendermint RPC endpoints. (Is it necessary to implement the unsafe methods too?)
What's the definition of "done" for this issue?
When we have RPC client support for the following additional endpoints:
/block_by_hash
/dump_consensus_state
/consensus_params
(Add/consensus_params
RPC endpoint #972)/unconfirmed_txs
/num_unconfirmed_txs
/block_search
(Addblock_search
RPC endpoint #991)/tx
(rpc: add support for/tx
endpoint #863)/check_tx
/header
(Side-by-side support for Tendermint 0.34 and 0.37 #1193)The text was updated successfully, but these errors were encountered: