Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: add support for /tx endpoint #863

Merged
merged 1 commit into from
Apr 28, 2021

Conversation

tony-iqlusion
Copy link
Collaborator

Support for finding a transaction directly by its hash.

In theory this endpoint should have read-your-writes (RYW) consistency whereas /tx_search does not.

See: tendermint/tendermint#6359

@tarcieri tarcieri force-pushed the tony-iqlusion/rpc-tx-endpoint branch from 2e4ec79 to a12ae04 Compare April 16, 2021 16:36
Support for finding a transaction directly by its hash.

In theory this endpoint should have read-your-writes (RYW) consistency
whereas `/tx_search` does not.

See: tendermint/tendermint#6359
@tarcieri tarcieri force-pushed the tony-iqlusion/rpc-tx-endpoint branch from a12ae04 to 03860fb Compare April 16, 2021 16:38
@codecov-commenter
Copy link

Codecov Report

Merging #863 (2ae6986) into master (4fa065b) will increase coverage by 0.1%.
The diff coverage is 96.3%.

❗ Current head 2ae6986 differs from pull request most recent head 03860fb. Consider uploading reports for the commit 03860fb to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##           master    #863     +/-   ##
========================================
+ Coverage    67.0%   67.1%   +0.1%     
========================================
  Files         212     213      +1     
  Lines       16771   16823     +52     
========================================
+ Hits        11244   11299     +55     
+ Misses       5527    5524      -3     
Impacted Files Coverage Δ
rpc/src/client.rs 16.9% <ø> (ø)
rpc/src/endpoint/tx_search.rs 10.0% <ø> (-6.7%) ⬇️
rpc/src/endpoint/tx.rs 50.0% <50.0%> (ø)
rpc/src/method.rs 29.2% <50.0%> (+0.9%) ⬆️
rpc/tests/parse_response.rs 98.0% <100.0%> (+0.3%) ⬆️
rpc/src/error.rs 50.4% <0.0%> (-1.5%) ⬇️
testgen/src/header.rs 78.1% <0.0%> (-0.7%) ⬇️
abci/src/server.rs 7.6% <0.0%> (+<0.1%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fa065b...03860fb. Read the comment docs.

Copy link
Contributor

@thanethomson thanethomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants