-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[zuul] Add job to deploy from nightly bundles #494
Conversation
This job doesn't build STF, but deploys from teh pre-built and published bundles. This is useful to be able to do periodically to make sure our latest bundles are deploying, and no dependencies are out-of-date, for example
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/73888c03c938441ca2a17d8fcf29594e ❌ stf-crc-latest-nightly_bundles RETRY_LIMIT in 10m 36s |
|
||
__local_build_enabled: false | ||
__deploy_from_bundles_enabled: true | ||
__service_telemetry_storage_ephemeral_enabled: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does CRC provide pre-configured PVs? I'd actually prefer if we could stop using ephemeral storage in our testing scenarios if possible. It's probably not a huge deal, but since our documentation uses persistent storage, it'd be ideal to test that part of the code path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that ephemeral storage was only used historically because there is no PV in quicklab, where our tests were originally running. We should be trying to use persistent storage whenever possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, if CRC will provide PVs, that would be ideal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's something to try later, I think. This set of jobs (local_build, local_build-index_deploy, nightly-bundles) need to get merged first so we have testing on PRs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a spike to the next sprint to try answer these questions, and scope adding PVs. It might be trivial, not possible or require changes in rdo-jobs
@@ -0,0 +1,7 @@ | |||
--- | |||
# from: https://github.com/infrawatch/service-telemetry-operator/pull/437 | |||
# ansible-playbook -e __service_telemetry_storage_ephemeral_enabled=true -e __local_build_enabled=false -e __deploy_from_bundles_enabled=true -e __service_telemetry_bundle_image_path=quay.io/infrawatch-operators/service-telemetry-operator-bundle:nightly-head -e __smart_gateway_bundle_image_path=quay.io/infrawatch-operators/smart-gateway-operator-bundle:nightly-head --skip-tags bundle_registry_tls_ca --skip-tags bundle_registry_auth build/run-ci.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might have to start considering tests that span stable-1.5
and master
since the nightly builds are results from different branches and thus different code bases. As we move towards STF 2.0 (and even STF 1.5.4) we'll have different code bases that could really both use separate test paths.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(not for now, I'm happy to just see this start landing against master
for now, but this code will eventually make its way into a stable-1.5 branch at some point, and we'll need to make some adjustments when that happens in a week or two)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This nightly check might well just run periodically, once a week or so.
To get tests spanning multiple branches, we need to add the job to that branch.
I think we also need a few more updates to get it working, but I'm focussing on getting the jobs on master first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep makes sense. Just noting that once we merge this to stable-1.5 as part of STF 1.5.3 then these will technically be the wrong tags.
|
||
__local_build_enabled: false | ||
__deploy_from_bundles_enabled: true | ||
__service_telemetry_storage_ephemeral_enabled: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, if CRC will provide PVs, that would be ideal.
Updated the branch to catch the changes that merged from #496 |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/874047479c7e46b7933ad772b27f2438 ❌ stf-crc-latest-nightly_bundles RETRY_LIMIT in 8m 26s |
The format was incorrect, and cannot include '#' or capital letters.
The format was incorrect, and cannot include '#' or capital letters.
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/fa350b8a5bd8402a8d9d934c25a1a92a ❌ stf-crc-latest-nightly_bundles FAILURE in 23m 53s |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/b6d91bd4bf224a2facd835fcb7348440 ❌ stf-crc-latest-nightly_bundles FAILURE in 23m 06s |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/b19bcdf0c84c411a8439548e2ed42e0c ❌ stf-crc-latest-nightly_bundles FAILURE in 25m 52s |
recheck |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/63d28c316165423ba6d484ae7ac8bef7 ❌ stf-crc-latest-nightly_bundles FAILURE in 26m 22s |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/6be43232faa84c5a9707add2fd92d643 ❌ stf-crc-latest-nightly_bundles FAILURE in 36m 14s |
recheck |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/f2a7fa4d7dff4a938d94d03ed3e0a439 ❌ stf-crc-latest-nightly_bundles FAILURE in 36m 23s |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/17c52c84331942dc98396336afb0688c ❌ stf-crc-latest-nightly_bundles FAILURE in 36m 05s |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/1897c65d5ddc4097afcda12a61e3e95d ❌ stf-crc-latest-nightly_bundles FAILURE in 37m 03s |
recheck I changed the base of the PR |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/078a29f485d5407a8255afe5479d5abd ❌ stf-crc-latest-nightly_bundles FAILURE in 37m 06s |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/f57e4c8592774b5995659fd636f5d69b ❌ stf-crc-latest-nightly_bundles RETRY_LIMIT in 15m 20s |
recheck |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/c42a34980eed43da8ee6c94d482c5068 ❌ stf-crc-latest-nightly_bundles FAILURE in 37m 40s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can merge now right? Nice work!
This job doesn't build STF, but deploys from the pre-built and published bundles.
This is useful to be able to do periodically to make sure our latest bundles are deploying, and no dependencies are out-of-date, for example
Depends-On: #496
Depends-On: #497